Deprecate overloaded setProfile, prefer setProfilingMode#1934
Merged
headius merged 1 commit intojruby:jruby-1_7from Nov 2, 2014
Merged
Conversation
The ScriptingContainer class contains two methods named `setProfile`, which differ only by their single argument type and do very different things from one another. One of the two signatures accepts an argument of type `ProfilingMode`, which, in other places in the code, is exposed via more explicitly named accessor methods such as `getProfilingMode` and `setProfilingMode`. I'm wondering if maybe the method in `ScriptingContainer` was simply accidentally mis-named. This commit deprecates the `setProfile(ProfilingMode)` method, and introduces a replacement method `setProfilingMode(ProfilingMode)`, which is more consistent with the rest of the code.
cprice404
force-pushed
the
maint/jruby-1_7/sc-set-profiling-mode
branch
from
e0accef to
05655cc
Compare
Member
|
Seems reasonable. |
headius
added a commit
that referenced
this pull request
Nov 2, 2014
…ing-mode Deprecate overloaded `setProfile`, prefer `setProfilingMode`
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ScriptingContainer class contains two methods named
setProfile,which differ only by their single argument type and do very different
things from one another. One of the two signatures accepts
an argument of type
ProfilingMode, which, in other places in thecode, is exposed via more explicitly named accessor methods such as
getProfilingModeandsetProfilingMode. I'm wondering if maybethe method in
ScriptingContainerwas simply accidentally mis-named.This commit deprecates the
setProfile(ProfilingMode)method, andintroduces a replacement method
setProfilingMode(ProfilingMode),which is more consistent with the rest of the code.