Fix the memory leak and actually close the resources.#1898
Merged
enebo merged 1 commit intojruby:jruby-1_7from Aug 13, 2014
Merged
Fix the memory leak and actually close the resources.#1898enebo merged 1 commit intojruby:jruby-1_7from
enebo merged 1 commit intojruby:jruby-1_7from
Conversation
enebo
added a commit
that referenced
this pull request
Aug 13, 2014
Fix the memory leak and actually close the resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #1888
I've opted for direct rename of getInputStream => openInputStream which technically can break people depending on it in 1.7.13 but in reality I doubt anyone started using that interface.
But I guess I can add a deprecated getInputStream back.