Module#ancestors now includes singletons themselves#1870
Merged
headius merged 1 commit intojruby:masterfrom Nov 2, 2014
robin850:singleton-ancestors
Merged
Module#ancestors now includes singletons themselves#1870headius merged 1 commit intojruby:masterfrom robin850:singleton-ancestors
headius merged 1 commit intojruby:masterfrom
robin850:singleton-ancestors
Conversation
Since Ruby 2.1, calling #ancestors on a singleton class should now include the class itself in the chain. Since BasicObject is at the very base of the ancestors, we also need to change the meta class of Object so that BasicObject's singleton class correctly get included in the chain.
headius
added a commit
that referenced
this pull request
Nov 2, 2014
Module#ancestors now includes singletons themselves
Member
|
Thanks to you and to @bbrowning! |
Contributor
Author
|
No problem, happy to contribute ! Just for the record I guess you snuck this pull request in the wrong milestone but there's no big deal ; thanks for merging. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Since Ruby 2.1, calling #ancestors on a singleton class should now include the class itself in the chain.
Since BasicObject is at the very base of the ancestors, we also need to change the meta class of Object so that BasicObject's singleton class correctly get included in the chain.
This patch has been written by @bbrowning!
Have a nice day!