Fix $LOAD_FEATURES paths for 1.8#1846
Merged
donv merged 1 commit intojruby:jruby-1_7from Jul 22, 2014
Merged
Conversation
Member
|
Looks good to me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 613673a, the paths in
$LOAD_FEATURESare formatted incorrectly in 1.8 mode. This causes Travis failures in allRUBYSPEC_LANG_VER='1.8'suites. See here for example.Travis after this fix looks like this (not green yet... but greener. The remaining reds are pre-existing and unrelated to this fix.)
@ratnikov please chime in if I've missed something here!