Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Concerning returning buffered stream to optimize file loads. I have looked into it, but behavior on my SSD seems pretty identical, whether to wrap BuffereInputStream with 8096 buffer or not. To test I've added a system properties to switch between the two strategies and used rails 4 and following command:
bin/jruby -e 'require "benchmark"; puts Benchmark.measure { require "rails/all" }'
Whether I turn buffering or not, the result is usually around 25seconds CPU time (sometimes bumping up to 34 for either case). But maybe that's because seek time is not a factor for SSDs, so I will try it on a regular hard drive on Monday.