Fix minor bug in setNativeEnabled, and expose it in ScriptingContainer#1803
Merged
enebo merged 2 commits intojruby:jruby-1_7from Jul 16, 2014
Merged
Fix minor bug in setNativeEnabled, and expose it in ScriptingContainer#1803enebo merged 2 commits intojruby:jruby-1_7from
setNativeEnabled, and expose it in ScriptingContainer#1803enebo merged 2 commits intojruby:jruby-1_7from
Conversation
The implementation of setNativeEnabled previously had a hard-coded value of `false`, and ignored the actual value that the caller passed in.
enebo
added a commit
that referenced
this pull request
Jul 16, 2014
Fix minor bug in `setNativeEnabled`, and expose it in ScriptingContainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two commits. The first simply fixes a minor bug in the implementation of
setNativeEnabled, where the parameter was being ignored and the value was always being set tofalse.The second commit adds accessor methods for
nativeEnabledto theScriptingContainerclass.