Make Time#to_r consistent with MRI#1790
Merged
enebo merged 1 commit intojruby:masterfrom Jul 9, 2014
robin850:time-to-r
Merged
Make Time#to_r consistent with MRI#1790enebo merged 1 commit intojruby:masterfrom robin850:time-to-r
enebo merged 1 commit intojruby:masterfrom
robin850:time-to-r
Conversation
Let's make JRuby matches the behavior of MRI when calling to_r on a Time object. It used to return only the numerator of the Rational object if the denominator was equal to 1.
enebo
added a commit
that referenced
this pull request
Jul 9, 2014
Make Time#to_r consistent with MRI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
There is an inconsistency between MRI and JRuby when dealing with a
Timeobject then callingto_ron it. JRuby returns simply the numerator of theRationalif the latter has 1 as its denominator.The commit introducing this feature is e748f0d ; this
ifcall was there to make this spec to pass but it has been updated later (thanks Ben Browning for the investigation work here).This makes the following assertion to pass now.
Have a nice day.