Refactor LoadService to make use of resources#1750
Merged
enebo merged 4 commits intojruby:jruby-1_7from Jul 9, 2014
Merged
Conversation
enebo
added a commit
that referenced
this pull request
Jul 9, 2014
Refactor LoadService to make use of resources
Member
|
My comments will be addressed by @ratnikov in future PR(s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a very heavy refactor of require/load logic. The new version resides in a new LibrarySearcher class, whereas the old methods are deprecated and are not being invoked anymore.
There are four main paths for loading a file:
1-3 are now being handled by LibrarySearcher. 4) still resides as a backdrop in LoadService with intent to being deprecated as well, once a ClasspathResource implementation of FileResource exists.