String#rindex should handle matchdata strings#1714
Merged
enebo merged 1 commit intojruby:jruby-1_7from Jun 14, 2014
Merged
Conversation
A string extracted from a matchdata object shares the same byte array as the string it was matched against. When doing a rindex between a string from a matchdata and the string the matchdata was matched against the same byte array is passed into ByteList.memcmp which will always return 0 as ByteList.memcmp just checks for equality of the byte arrays. I fix this by passing bytes() instead getUnsafeBytes() into the ByteList.memcmp method so that the byte arrays are different. Fixes jruby#1688
enebo
added a commit
that referenced
this pull request
Jun 14, 2014
String#rindex should handle matchdata strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A string extracted from a matchdata object shares the same
byte array as the string it was matched against. When doing a
rindex between a string from a matchdata and the string the matchdata
was matched against the same byte array is passed into
ByteList.memcmpwhich will always return 0 as
ByteList.memcmpjust checks for equalityof the byte arrays.
I fix this by passing
bytes()insteadgetUnsafeBytes()into theByteList.memcmpmethod so that the byte arrays are different.Fixes #1688