Closed
Conversation
Member
Author
|
The travis failure is the same as for master. |
…by into ssl_treat_not_handshaking_as_finished
Member
Author
|
Committed the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code comment states that NOT_HANDSHAKING should be treated as FINISHED, but fails to reset the
initialHandshakeflag.On Android, client connections complete OK in the NOT_HANDSHAKING state. This may be a bug on Android, but it has not changed since Android 2.3, and current source suggests it will stay that way ( https://android.googlesource.com/platform/libcore/+/master/luni/src/test/java/libcore/javax/net/ssl/SSLEngineTest.java )
The fix is to treat NOT_HANDSHAKING as FINISHED as per code comment. Tests run fine on OS X and travis as far as I can see.