StringIO.set_encoding may change shared ByteList encoding#1699
Merged
enebo merged 1 commit intojruby:masterfrom May 21, 2014
intentmedia:stringio_modify_before_set_encoding
Merged
StringIO.set_encoding may change shared ByteList encoding#1699enebo merged 1 commit intojruby:masterfrom intentmedia:stringio_modify_before_set_encoding
enebo merged 1 commit intojruby:masterfrom
intentmedia:stringio_modify_before_set_encoding
Conversation
enebo
added a commit
that referenced
this pull request
May 21, 2014
…encoding StringIO.set_encoding may change shared ByteList encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a StringIO instance with no arguments, ptr.string references the shared EMPTY_BYTELISTS instance for that encoding.
It is possible to then call set_encoding to change the encoding on the shared instance.
This fix is to duplicate the value before changing the encoding.