Static JavaProxy#getJavaClass needs to clear $!#1636
Merged
enebo merged 1 commit intojruby:jruby-1_7from Apr 16, 2014
Merged
Conversation
Calls from Ruby which go through JavaProxy.getJavaClass (ie. field_writer, field_reader, and field_accessor) can result in $! incorrectly containing a NoMethodError from its attempt to invoke "java_class". Ensure we clear it in the catch block.
enebo
added a commit
that referenced
this pull request
Apr 16, 2014
Static JavaProxy#getJavaClass needs to clear $!
Member
|
Seems very reasonable to me and this is beginning of dev cycle. If someone is hoping to look at $! even though there was no raise in this scenario then that is some really weird Ruby JI code... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls from Ruby which go through the static
JavaProxy.getJavaClass(ie.field_writer,field_reader, andfield_accessor) can result in$!incorrectly containing aNoMethodErrorfrom its attempt to invokejava_class. Ensure we clear it in the catch block.(I stumbled on this because Minitest was loading all tests up but then executing none of them because
'$!wasn't clear)