Conversation
|
I guess that we give this PR some attention after the jruby-1.7.11 release |
|
@mkristian sure thing |
|
Ok, merging into 1.7.12. |
|
Ok, I think I've got this all merged. jruby-1_7 still has the files in-place and does not use @mkristian's new magic to install and copy them from the gems. @mkristian would it be too risky to do that on jruby-1_7 branch as well? cc @enebo. master does use the default gem install+copy step mkristian made, so I just updated krypt version there to 0.0.2.rc1 and it appears to install and copy correctly. |
|
If we plan on supporting 1.7 branch for a long time it would be nice for all the logic and process to line up. It is the beginning of 1.7.12 dev cycle so I think we should go for it. |
|
if this is consensus to do the same, I can merge it. I did not do it before |
|
We have a 2-3 weeks to make sure it works so I think we can work out the kinks. Unless you are worried about some hidden risk. With the plan to maintain jruby-1_7 branch for a long time we might need to be slightly more risky in order to keep the branches from drifting too far apart (obviously part of the goal is to change APIs and stuff, but the stuff we can keep in sync we should try barring huge risk). |
|
no not risky and there are tests in place ;) |
|
actually then it will be easy to include bundler into jruby ;) |
|
Feel free to ping me if you guys find any issue or need help |
Good morning guys, I did the codebase synchronization against the latest release of Krypt (https://rubygems.org/gems/krypt/versions/0.0.2.rc1), but I couldn't find lib/pom.xml to update the gem version.
Let me know if something is not ok.