Change to use FileResource to get entries for RubyDir#1526
Merged
enebo merged 2 commits intojruby:jruby-1_7from Mar 3, 2014
Merged
Change to use FileResource to get entries for RubyDir#1526enebo merged 2 commits intojruby:jruby-1_7from
enebo merged 2 commits intojruby:jruby-1_7from
Conversation
added 2 commits
March 2, 2014 13:49
Current jar Dir.entries implementation doesn't return "." and ".." so to keep this behavior in 1.7, I've moved the "." and ".." addition logic to RegularFileResource. Unfortunately fixing the jar files to support such behavior would require and invasive refactor of File/Dir implementations to be able to support expanding '..' in jar file names.
Contributor
Author
|
This PR replaces using JarFile directly from RubyDir in favor of using file resources. It is ready for merge. |
enebo
added a commit
that referenced
this pull request
Mar 3, 2014
Change to use FileResource to get entries for RubyDir (will follow up to re-add the non-TC initialize methods for backwards compat)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might fix #1100 although I haven't verified this yet.