Skip to content

correct visibility of initialize* and respond_to_missing? methods#1516

Merged
1 commit merged intojruby:masterfrom
tduehr:initialize_fix
Feb 26, 2014
Merged

correct visibility of initialize* and respond_to_missing? methods#1516
1 commit merged intojruby:masterfrom
tduehr:initialize_fix

Conversation

@tduehr
Copy link
Contributor

@tduehr tduehr commented Feb 20, 2014

No description provided.

@enebo enebo added this to the JRuby 9000 milestone Feb 21, 2014
@headius
Copy link
Member

headius commented Feb 21, 2014

A few of the failures look bogus, but most look valid (visibility errors). Something's not right.

@tduehr
Copy link
Contributor Author

tduehr commented Feb 21, 2014

I'll take a look through them and reconcile with MRI.

@tduehr
Copy link
Contributor Author

tduehr commented Feb 21, 2014

There is definitely something weird going on here.

This spec is up to date but the results are wrong for MRI too. It's checking that initialize_clone doesn't appear in the public methods not that an exception is raised.

https://github.com/rubyspec/rubyspec/blob/master/core/kernel/initialize_clone_spec.rb

https://gist.github.com/tduehr/9144875

@tduehr
Copy link
Contributor Author

tduehr commented Feb 24, 2014

Is there a way to remove these methods from the methods listings without a special case in #methods for now?

@headius
Copy link
Member

headius commented Feb 26, 2014

@tduehr No simple way to remove those methods from the listings. I'm going to poke at this a bit.

@headius
Copy link
Member

headius commented Feb 26, 2014

I think we need to update master to latest rubyspec; many of these cases have been fixed as being bad tests.

@headius
Copy link
Member

headius commented Feb 26, 2014

It looks like other specs fail because mspec is not handling respond_to_missing? being private correctly.

@ghost ghost merged commit acf5d25 into jruby:master Feb 26, 2014
@headius
Copy link
Member

headius commented Feb 26, 2014

Ok, I updated two specs (Kernel#initialize_clone and initialize_dup) and updated mspec and things appear to passing ok locally. We'll see how travis feels, but for now it's merged.

@enebo
Copy link
Member

enebo commented Feb 26, 2014

Any chance we can get a similar PR for missing private for Ruby 18/19 on jruby-1_7? I am betting we are missing a few there as well.

@tduehr
Copy link
Contributor Author

tduehr commented Mar 3, 2014

#1542

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants