Enumerator#each_with_object should provide the yielder's return value to its block#1440
Merged
enebo merged 1 commit intojruby:jruby-1_7from Jan 27, 2014
Merged
Conversation
Make Enumerator#each_with_object return its yielder's value to match MRI
enebo
added a commit
that referenced
this pull request
Jan 27, 2014
Enumerator#each_with_object should provide the yielder's return value to its block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a simple illustration of the problem:
This fix also lets us un-exclude
test_enumerator#test_with_objectas thedelete_if.with_objectassertion in there was failing because it implicitly relies on this behavior (I also added a regression spec explicitly testing this case).(Note: I validated that Travis is pleased with this change. The failures we'll get here are fixed in #1439)