Restore hex and random_bytes to SecureRandom 1.8 (fixes Travis)#1439
Merged
enebo merged 1 commit intojruby:jruby-1_7from Jan 27, 2014
Merged
Restore hex and random_bytes to SecureRandom 1.8 (fixes Travis)#1439enebo merged 1 commit intojruby:jruby-1_7from
enebo merged 1 commit intojruby:jruby-1_7from
Conversation
The refactor which replaced hex and random_bytes with native code in SecureRandom accidentally left them broken for 1.8. Restored!
Contributor
Author
|
Heh. Of course Travis fails when I say "this gets it green". The failure here is due to network flakiness. Will be green on subsequent runs. |
enebo
added a commit
that referenced
this pull request
Jan 27, 2014
Restore hex and random_bytes to SecureRandom 1.8 (fixes Travis)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refactor which replaced hex and random_bytes with native code in SecureRandom accidentally left them broken for 1.8 (the commit which native-ed uuid moved the native extension loading behind a Ruby 1.9-only check). Restored!
This gets
jruby-1_7Travis green.