Cache DecimalFormatSymbols instances to reduce lock contention#1414
Merged
headius merged 1 commit intojruby:jruby-1_7from Jan 17, 2014
Merged
Cache DecimalFormatSymbols instances to reduce lock contention#1414headius merged 1 commit intojruby:jruby-1_7from
headius merged 1 commit intojruby:jruby-1_7from
Conversation
Constructing new DecimalFormatSymbol instances requires locking, and in some sample Rails apps this contention was bubbling up as a bottleneck. So, this change caches DecimalFormatSymbol instances per-thread just like NumberFormat instances are already cached. The overall throughput in my test application wasn't much changed because of ActiveRecord's connection mutex still sitting in this way, but this does get rid of one source of multi-threaded lock contention.
headius
added a commit
that referenced
this pull request
Jan 17, 2014
Cache DecimalFormatSymbols instances to reduce lock contention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructing new DecimalFormatSymbols instances requires locking, and
in some sample Rails apps this contention was bubbling up as a
bottleneck. So, this change caches DecimalFormatSymbols instances
per-thread just like NumberFormat instances are already cached.
The overall throughput in my test application wasn't much changed
because of ActiveRecord's connection mutex still sitting in this way,
but this does get rid of one source of multi-threaded lock contention.