Fixing Enumerator#peek behaviour#1336
Merged
enebo merged 1 commit intojruby:jruby-1_7from Dec 15, 2013
lucasallan:enumerator-peek
Merged
Fixing Enumerator#peek behaviour#1336enebo merged 1 commit intojruby:jruby-1_7from lucasallan:enumerator-peek
enebo merged 1 commit intojruby:jruby-1_7from
lucasallan:enumerator-peek
Conversation
…eady at the end and method peek is called then JRuby was throwing a NullPointerException. But the correct behaviour should be raise a StopIteration.
enebo
added a commit
that referenced
this pull request
Dec 15, 2013
Fixing Enumerator#peek behaviour
Member
|
Thanks Lucas, I should have mentioned that test/externals/ruby1.9 is actually MRI's 1.9 test suite. I committed it anyways but if we ever resync your test will disappear (which I think is fine so long as you open an issue and get this test added to MRI or rubyspecs test suite). |
Member
Author
|
@enebo thanks you very much. I sent a pul request to mri with these tests ruby/ruby#479 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@enebo I closed the old pull request and opened this one to be merged on jruby-1_7 as you asked.