Skip to content

Array#repeated_permutation should have arity 1#1335

Merged
enebo merged 1 commit intojruby:jruby-1_7from
dmarcotte:repeat-perm-arg
Dec 13, 2013
Merged

Array#repeated_permutation should have arity 1#1335
enebo merged 1 commit intojruby:jruby-1_7from
dmarcotte:repeat-perm-arg

Conversation

@dmarcotte
Copy link
Contributor

@dmarcotte dmarcotte commented Dec 13, 2013

Remove arg-less Array#repeated_permutation to match MRI behavior. (Noticed this implementing Array#repeated_permutation.size: it relies on #repeated_permutation having an arg)

$ ruby -e "p [].repeated_permutation"
-e:1:in `repeated_permutation': wrong number of arguments (0 for 1) (ArgumentError)
    from -e:1:in `<main>'

vs.

$ jruby -e "p [].repeated_permutation"
#<Enumerator: []:repeated_permutation>

@dmarcotte
Array#repeated_permutation should have arity 1
89a7ba2 
Remove arg-less Array#repeated_permutation to match MRI behavior.
enebo added a commit that referenced this pull request Dec 13, 2013
@enebo
Merge pull request #1335 from dmarcotte/repeat-perm-arg
8db840c 
Array#repeated_permutation should have arity 1
@enebo enebo merged commit 8db840c into jruby:jruby-1_7 Dec 13, 2013
@enebo enebo modified the milestones: JRuby 1.7.10, JRuby 1.7.11 Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 1.7.10

Development

Successfully merging this pull request may close these issues.

2 participants

@dmarcotte @enebo