Skip to content

Fix Enumerable#slice_before arg handling #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 1 commit into from
Nov 25, 2013
Merged

Fix Enumerable#slice_before arg handling #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/main/ruby/jruby/kernel19/enumerable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ def slice_before(filter = (no_filter = true; nil), &block)

Enumerator.new do |yielder|
ary = nil
self.each do |elt|
self.each do |*elt|
if elt.size < 2
elt = elt.size == 0 ? nil : elt[0]
end

if block
if no_filter
state = block.call elt
Expand Down
8 changes: 8 additions & 0 deletions spec/regression/GH-744_GH-264_enum_args_using_call_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,14 @@ def each(&block)
it_behaves_like "an Enumerable method which takes a block", :array
end

describe "Enumerable#slice_before" do
it "passes all #each args to its block" do
@test_enum.slice_before do |obj|
obj.should == [1, 2, 3]
end.each{}
end
end

describe "Enumerable#flat_map" do
subject { :flat_map }
it_behaves_like "an Enumerable method which takes a block", :first_arg
Expand Down