openssl: add handling for base 0 to new and to_s#1221
Closed
arnehormann wants to merge 1 commit intojruby:masterfrom
arnehormann:openssl-mpint
Closed
openssl: add handling for base 0 to new and to_s#1221arnehormann wants to merge 1 commit intojruby:masterfrom arnehormann:openssl-mpint
arnehormann wants to merge 1 commit intojruby:masterfrom
arnehormann:openssl-mpint
Conversation
Member
|
Thank you! Is there a test we could enable for this behavior? |
Contributor
Author
|
I had to read the C documentation and experimented quite a lot with IRB to get this where it is now (and the MRI documentation is pretty much lacking in this regard). I would have attempted to write a test, but I didn't know where to put it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OpenSSL::BN, base 0 is used in
to_sandnewto convert to and from a multi precision integer as specified in RFC #4251 Section 5: mpint.I stumbled over this while fixing a pull request for sshkey running under JRuby.
That's also what I used for testing - I ran
rake testwith the JRuby rake implementation for my first commit from the sshkey pull request.