Fix compatibility wiht Bouncy Castle 1.49.#1157
Closed
voxik wants to merge 1 commit intojruby:masterfrom
Closed
Conversation
Member
|
I wonder if there are any tests for such functionality (that is where I dropped my patch before) ? |
Contributor
Author
|
Well, hard to say ... I am still far from being able to run the test suite, but I can compile this bit at least :) |
Member
|
Are there versioned API docs? How far back do we need to go to support these newer signatures? |
Member
|
I'm going to look at this and see if it passes tests. |
Member
|
The code appears to merge and pass all tests just fine on JRuby master. I don't think there are objections to merging there, but since we maintain jruby-openssl and bouncy-castle gems across older JRuby impls, we may want to discuss whether to merge now or not. |
Member
|
Merged into 1.7 and master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am trying to update JRuby packages in Fedora and it seems that JRuby is not compatible with Bouncy Castle 1.49:
I come with this patch to fix the compatibility. I would appreciate if you can accept