Fixes JRuby #1047 - incorrect test for whether a kw arg was provided.#1048
Closed
97jaz wants to merge 1 commit intojruby:masterfrom
97jaz:1047-kwargs
Closed
Fixes JRuby #1047 - incorrect test for whether a kw arg was provided.#104897jaz wants to merge 1 commit intojruby:masterfrom 97jaz:1047-kwargs
97jaz wants to merge 1 commit intojruby:masterfrom
97jaz:1047-kwargs
Conversation
Formerly, the code attempted to extract the argument value from the hash of provided values and test it against nil. This fails in the case of an explicitly passed nil. The new version instead tests whether the hash contains the desired key.
Contributor
Author
|
Closing in favor of #1054 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formerly, the code attempted to extract the argument value from the
hash of provided values and test it against nil. This fails in the
case of an explicitly passed nil. The new version instead tests
whether the hash contains the desired key.
Fixes #1047