Repository navigation
Conversation
Copied whole from ruby/ruby@197b8f0103 (Ruby 4.1.0-dev). The new tests that fail on JRuby are excluded with the reason. test_dup and test_regexp2 now expect frozen Regexp instances (Feature jruby#8948). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Review and merge order for the Regexp freeze work (Feature #8948):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
test/mri/ruby/test_regexp.rbandtest_marshal.rbto the current CRuby copies (ruby/ruby@197b8f0103, Ruby 4.1.0-dev). Both files are copied whole; our previous copies came from CRuby 4.0.0 with no local edits.The Regexp freeze PR needs this: CRuby changed three assertions in ruby/ruby@cb03bf43eb to expect frozen Regexp instances.
Excludes
The new tests that fail on JRuby are excluded, with what fails:
TestRegexp:test_dupandTestMarshal#test_regexp2(Regexp instances frozen, removed by the freeze PR), plustest_too_many_range_repeat,test_too_many_null_check,test_nested_repeat_expansion_overflow(noRegexpError),test_index_with_assertion_before_leading_anychar_starandtest_rindex_with_leading_anychar_star_multiline(String#index/rindexreturnnil),test_s_timeout_corner_casesandtest_timeout_corner_cases(noArgumentErrorfor out-of-range timeouts),test_extended_comment_invalid_unicode_escape_with_multibyte_characters(SyntaxError),test_once_implicit_match, and four that need CRuby-only APIs (RubyVM,RbConfig::LIMITS,assert_no_memory_leak).TestMarshal:test_bignum_len_overflow(JavaNegativeArraySizeExceptionleaks out),test_load_overreadandtest_load_overread_string_body(no support for a source that only responds toread),test_marshal_false_proc,test_modify_string_during_dump,test_uclass_module_not_relabeled,test_user_class_struct_size,test_continuation(needs callcc).TestMarshalFreeze#test_uclass_fstring.Several of these are real bugs worth separate fixes; I left them for follow-up PRs.
Testing
Both files, interpreter and forced JIT, on this branch: 0 failures (
test_regexp.rb126 tests,test_marshal.rb190 tests).🤖 Generated with Claude Code