Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/src/main/java/org/jruby/RubySignal.java
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
import static org.jruby.api.Create.newHash;
import static org.jruby.api.Create.newString;
import static org.jruby.api.Define.defineModule;
import static org.jruby.api.Error.argumentError;

@JRubyModule(name="Signal")
public class RubySignal {
Expand Down Expand Up @@ -208,7 +207,7 @@ public static IRubyObject signame(ThreadContext context, final IRubyObject recv,
if (signame == null) {
if (sig == 0) return newString(context, "EXIT");

throw argumentError(context, "invalid signal number: " + rubySig);
return context.nil;
}

return newString(context, signame);
Expand Down
5 changes: 5 additions & 0 deletions spec/ruby/core/signal/signame_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
-> { Signal.signame(obj) }.should.raise(TypeError)
end

it "raises a RangeError when the passed argument is out of range of int" do
-> { Signal.signame(2**31) }.should.raise(RangeError)
-> { Signal.signame(-2**31 - 1) }.should.raise(RangeError)
end

platform_is_not :windows do
it "the original should take precedence over alias when looked up by number" do
Signal.signame(Signal.list["ABRT"]).should == "ABRT"
Expand Down
1 change: 0 additions & 1 deletion spec/tags/ruby/core/signal/signame_tags.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
fails:Signal.signame returns nil if the argument is an invalid signal number
fails:Signal.signame the original should take precendence over alias when looked up by number
fails:Signal.signame the original should take precedence over alias when looked up by number
Loading