Repository navigation
Conversation
headius
force-pushed
the
work/perfect-argument-passing
branch
from
November 14, 2026 14:39
729df42 to
a6bf015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the IR hash keyword marker through simplification, cloning, inlining, and persistence. Prism now marks simple symbol-keyword arguments when building call arguments. Bump the persisted IR format version for the added field, and clarify that
CallArgumentdescribes an outgoing JVM stack slot.This is Stage 1 groundwork for the argument-passing follow-up to #9219. Broader call shapes and callee-side direct binding remain open.
Validation
./mvnw -q -DskipTests -pl core,shaded package— passed./mvnw -q -pl core -Dtest=HashTest test— passedrake spec:compiler— 607 examples, 0 failures, 8 pendingbin/jruby -Xparser.prism -S rake spec:compiler— 607 examples, 0 failures, 8 pending