Repository navigation
Remove one-line wrappers from Queue's fiber scheduler code - #10045
Merged
headius merged 2 commits intoNov 13, 2026
Merged
Conversation
Call the waiter helpers on the two lists directly instead of through one-line wrappers, and reuse Mutex's SchedulerWaiters type. In schedulerBlock, a push flag picks the list and the ready check, so callers no longer pass a list and a lambda.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review of #9805, where the Queue scheduler code was noted as repetitive. This is a small local cleanup, not the shared "scheduler is active" abstraction across classes discussed there. Behavior does not change.
unblockSchedulerTakerand others) and call the helpers directly.SchedulerWaiterstype instead of declaring its own copy.schedulerBlocktakes a push/pop flag and checks readiness in one method, instead of taking a list and a lambda from each caller.The removed protected members (
Queue.SchedulerWaiters,unblockSchedulerTakerand others) were added in 10.1.3 for this code only, so I removed them without a deprecation step.