some line numbers on warnings are off by 1 #7741
Description
some line numbers are (still) -=1, mostly those captured from caller:
puts 'start'
#'foo'.lines { :ignored_block } # line 2
[1, 2].find_index(3) { :unused_block } # 3
Array.new(2, false) { :superseded } # 4
Array.class_eval do
alias_method :hash, :size # 6
end
:done # 8expected behavior:
ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x86_64-linux]
jruby_warning_test.rb:8: warning: possibly useless use of a literal in void context
start
jruby_warning_test.rb:3: warning: given block not used
jruby_warning_test.rb:4: warning: block supersedes default value argument
jruby_warning_test.rb:6: warning: method redefined; discarding old hash
actual behavior:
jruby 9.4.2.0 (3.1.0) 2023-03-08 90d2913fda OpenJDK 64-Bit Server VM 11.0.14.1+1 on 11.0.14.1+1 +jit [x86_64-linux]
jruby_warning_test.rb:8: warning: possibly useless use of a literal in void context
start
jruby_warning_test.rb:3: warning: given block not used
jruby_warning_test.rb:4: warning: block supersedes default value argument
jruby_warning_test.rb:7: warning: method redefined; discarding old hash
the last warning has line += 1
believe this issue existed all the way back to 9.2
Metadata
Metadata
Assignees
Labels
No labels