Skip to content

Address all tests failing with asserts enabled #5692

@headius

Description

@headius

In #5612 (comment), @kares fixed our builds to properly pass -ea flag down to child processes, and as a result a bunch of test suites went red. This may indicate these asserts are not correct, or that we have code that happens to work even though it violates valid asserts. Either way they all need to be addressed.

The patch is here:

diff --git a/bin/jruby.bash b/bin/jruby.bash
index 4e50cb0b5dc..7318d896deb 100755
--- a/bin/jruby.bash
+++ b/bin/jruby.bash
@@ -240,6 +240,7 @@ do
         else
             if [ "${val:0:3}" = "-ea" ]; then
                 VERIFY_JRUBY="yes"
+                java_args=("${java_args[@]}" "${1:2}")
             elif [ "${val:0:16}" = "-Dfile.encoding=" ]; then
                 JAVA_ENCODING=${val:16}
             elif [ "${val:0:20}" = "-Djava.security.egd=" ]; then

An example build showing all failed suites (for as long as it exists in Travis history) is here: https://travis-ci.org/kares/jruby/builds/518835139

Note that at least one of these failures is due to the issue reported in #5612.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions