Skip to content

ttymode, ttymode_yield should be private #4275

@olleolleolle

Description

@olleolleolle

JRuby exposes more parts of File as public instance methods than MRI does.

These two are made public in JRuby:

  • ttymode
  • ttymode_yield

Assumptions in FakeFS about that makes its asserts not pass. Update: FakeFS v0.10.0 changed it assumptions.

Environment

  • jruby 9.1.6.0 (2.3.1) 2016-11-09 0150a76 Java HotSpot(TM) 64-Bit Server VM 24.76-b04 on 1.7.0_76-b13 +jit [linux-x86_64]
  • Operating system: linux-x86_64 on Travis

Other relevant info you may wish to add:

Expected Behavior

File.instance_methods should exclude ttymode and ttymode_yield.

The test results in https://travis-ci.org/fakefs/fakefs/jobs/174750880 should not fail on ttymode_yield and ttymode

  • MRI has the above methods marked private (I think)
  • Here's a FakeFS test-case that checks File.instance_methods

Actual Behavior

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions