I modified the "release" profile to enable (unconditionally) the enforcer, and that appears to work without breaking non-release SNAPSHOT builds of JRuby.

I'll go with this but still need buy-in from @mkristian and @enebo.

diff --git a/pom.rb b/pom.rb
index 50c8e69..065be87 100644
--- a/pom.rb
+++ b/pom.rb
@@ -122,12 +122,6 @@ project 'JRuby', 'https://github.com/jruby/jruby' do
     plugin :jar, '2.6'

     rules = { :requireMavenVersion => { :version => '[3.3.0,)' } }
-    unless model.version =~ /-SNAPSHOT/
-       #rules[:requireReleaseDeps] = { :message => 'No Snapshots Allowed!' }
-    end
-    plugin :enforcer, '1.4' do
-      execute_goal :enforce, :rules => rules
-    end

     plugin :compiler, '3.3'
     plugin :shade, '2.4.3'
@@ -276,6 +270,9 @@ project 'JRuby', 'https://github.com/jruby/jruby' do
   end

   profile 'release' do
+    plugin :enforcer, '1.4' do
+      execute_goal :enforce, :rules => { requireReleaseDeps: { :message => 'No Snapshots Allowed!' } }
+    end
     modules [ 'truffle', 'test', 'maven' ]
     properties 'invoker.skip' => true
   end

Output:

...
[INFO] --- maven-enforcer-plugin:1.4:enforce (enforce-maven) @ jruby-core ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4:enforce (default) @ jruby-core ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireReleaseDeps failed with message:
No Snapshots Allowed!
Found Banned Dependency: com.github.jnr:jnr-constants:jar:0.9.3-SNAPSHOT
Use 'mvn dependency:tree' to locate the source of the banned dependencies.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] JRuby .............................................. SUCCESS [  1.515 s]
[INFO] JRuby Core ......................................... FAILURE [  1.257 s]
[INFO] JRuby Lib Setup .................................... SKIPPED
...

Uh oh!

9.1.3.0 and 9.1.4.0 have a -SNAPSHOT dependency #4135

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions