Use cached Ptr instances per-OpenFile

headius · headius · commit 5b112fc29113 · 2023-02-04T12:30:57.000-05:00
These Ptr instances are only ever read or written under lock, so
we can share them and reduce allocation along this hot path.
diff --git a/core/src/main/java/org/jruby/util/io/OpenFile.java b/core/src/main/java/org/jruby/util/io/OpenFile.java
@@ -154,6 +154,9 @@ public static class Buffer {
 
     protected volatile Set<RubyThread> blockingThreads;
 
+    private Ptr spPtr = new Ptr();
+    private Ptr dpPtr = new Ptr();
+
     public void clearStdio() {
         stdio_file = null;
     }
@@ -1202,8 +1205,8 @@ else if (cbuf.off + cbuf.len == cbuf.capa) {
 
             cbuf_len0 = cbuf.len;
 
-            Ptr spPtr = new Ptr();
-            Ptr dpPtr = new Ptr();
+            spPtr.p = 0;
+            dpPtr.p = 0;
 
             while (true) {
                 ss = spPtr.p = rbuf.off;
@@ -2359,11 +2362,11 @@ public SocketChannel socketChannel() {
     IRubyObject finishWriteconv(ThreadContext context, boolean noalloc) {
         byte[] dsBytes;
         int ds, de;
-        Ptr dpPtr = new Ptr();
         EConvResult res;
 
         boolean locked = lock();
         try {
+            dpPtr.p = 0;
             if (wbuf.ptr == null) {
                 byte[] buf = new byte[1024];
                 long r;
