WWA Security Conformance #253
Conversation
Unknown attributes, such as `t`, are not able to be set with innerHTML in Windows Web Apps. These must be set on elements via setAttribute instead.
Sizzle PR located at jquery/sizzle#253
src/sizzle.js
Outdated
There was a problem hiding this comment.
I'd much rather see t renamed to something like class or title than suffer the increased size here.
There was a problem hiding this comment.
Wasn't the purpose of t to trigger invalid attribute in XHTML? I assumed that much, which is why I didn't touch it. If that is not the case, I agree - more concise code here would be better.
If we don't need the t attribute, we could otherwise leave this code as-is using the straight-forward string assignment via innerHTML.
There was a problem hiding this comment.
No; we just need an attribute for the following ^='' test to detect and work around the IE8 & Opera 10-12 bugs.
Removing invalid attribute `t` which may cause security issues for some environments.
|
Used a standard attribute |
|
Looks like Sizzle didn't get updated? I don't see this commit in beta1. We're missing several commits, the Sizzle in the beta is from 2014-02-05. |
3 participants
Unknown attributes, such as
t, are not able to be set with innerHTMLin Windows Web Apps. These must be set on elements via setAttribute
instead.
Historical context: