Skip to content

Dialog: Add option to put the dialog title in a header element #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgol merged 17 commits into from
Sep 9, 2024
Merged

Dialog: Add option to put the dialog title in a header element #2275

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
14dc459
Add option to set html tag for dialog modal title
rpkoller Jul 31, 2024
c22ba5b
Fix the line length lint error
rpkoller Aug 1, 2024
564b793
Add test to assert if the html tag is correctly set
rpkoller Aug 1, 2024
6f8307d
tagName is not a function. Removed parenthesis
rpkoller Aug 1, 2024
8f8c2a1
add the missing tab for the second line of uiDialogTitle
rpkoller Aug 1, 2024
a277562
move the <> to the option
rpkoller Aug 1, 2024
9238fc0
adjust to the changes in dialog.js and set the option to <h2>
rpkoller Aug 1, 2024
d4aa8a0
fix for the test
rpkoller Aug 2, 2024
b2f3e72
fix linting errors on the test
rpkoller Aug 2, 2024
7b9ea13
fix another linting error on the test
rpkoller Aug 2, 2024
478e434
add new option to common.js and common-deprecated.js
rpkoller Aug 2, 2024
140fa73
use and accept integer values only for html element
rpkoller Aug 5, 2024
f46ff12
Add new tests for dialog title heading levels
rpkoller Aug 5, 2024
6ffab2e
change to the new default value 0 for uiDialogTitleHeadingLevel
rpkoller Aug 5, 2024
5652776
fix linting errors
rpkoller Aug 5, 2024
c70786d
fix dialog title heading level tests
rpkoller Aug 5, 2024
8f583cb
add another assertion for the dialog title heading lvl with option foo
rpkoller Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add new tests for dialog title heading levels
  • Loading branch information
@rpkoller
rpkoller committed Aug 5, 2024
commit f46ff12ea0aa61dbdf2e3e2a623cce1df5e7281e
32 changes: 28 additions & 4 deletions tests/unit/dialog/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,38 @@ QUnit.test( "aria-modal", function( assert ) {
element.remove();
} );

QUnit.test( "ui dialog title tagname", function( assert ) {
assert.expect( 1 );
QUnit.test( "ui dialog title heading level", function( assert ) {
assert.expect( 7 );

var element, nodeName;

element = $( "<div>" ).dialog( { modal: true, uiDialogTitleTagName: "<h2>" } );
element = $( "<div>" ).dialog( { modal: true } );
nodeName = element.dialog( "widget" ).find( ".ui-dialog-title" ).get( 0 ).nodeName.toLowerCase();
assert.equal( nodeName, "span", "The dialog title element is span" );

element = $( "<div>" ).dialog( { modal: true, uiDialogTitleTagName: 0 } );
nodeName = element.dialog( "widget" ).find( ".ui-dialog-title" ).get( 0 ).nodeName.toLowerCase();
assert.equal( nodeName, "span", "The dialog title element is span" );

element = $( "<div>" ).dialog( { modal: true, uiDialogTitleTagName: 1 } );
nodeName = element.dialog( "widget" ).find( ".ui-dialog-title" ).get( 0 ).nodeName.toLowerCase();
assert.equal( nodeName, "h1", "The dialog title element is h1" );

element = $( "<div>" ).dialog( { modal: true, uiDialogTitleTagName: 6 } );
nodeName = element.dialog( "widget" ).find( ".ui-dialog-title" ).get( 0 ).nodeName.toLowerCase();
assert.equal( nodeName, "h6", "The dialog title element is h6" );

element = $( "<div>" ).dialog( { modal: true, uiDialogTitleTagName: 9 } );
nodeName = element.dialog( "widget" ).find( ".ui-dialog-title" ).get( 0 ).nodeName.toLowerCase();
assert.equal( nodeName, "span", "The dialog title element is span" );

element = $( "<div>" ).dialog( { modal: true, uiDialogTitleTagName: -9 } );
nodeName = element.dialog( "widget" ).find( ".ui-dialog-title" ).get( 0 ).nodeName.toLowerCase();
assert.equal( nodeName, "span", "The dialog title element is span" );

element = $( "<div>" ).dialog( { modal: true, uiDialogTitleTagName: 2.3 } );
nodeName = element.dialog( "widget" ).find( ".ui-dialog-title" ).get( 0 ).nodeName.toLowerCase();
assert.equal( nodeName, "h2", "The dialog title element is h2" );
assert.equal( nodeName, "span", "The dialog title element is span" );
} );

QUnit.test( "widget method", function( assert ) {
Expand Down