Skip to content

Conversation

@timmywil
Copy link
Member

@timmywil timmywil commented Apr 4, 2024

  • one queue to rule them all: browserstack and selenium
  • retries and hard retries are now supported in selenium
  • selenium tests now re-use browsers in the same way as browserstack
  • also fix concurrency so no jobs are cancelled

Companion PR for jquery/jquery#5460 and jquery/jquery#5465

Sample test runs

3.x: https://github.com/timmywil/jquery-migrate/actions/runs/8548231361
git: https://github.com/timmywil/jquery-migrate/actions/runs/8548231364

@timmywil timmywil force-pushed the queue branch 2 times, most recently from 12e57b3 to 8bec395 Compare April 4, 2024 02:19
@timmywil timmywil requested a review from mgol April 4, 2024 02:59
@timmywil timmywil added this to the 3.5.0 milestone Apr 4, 2024
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgol
Copy link
Member

mgol commented Apr 4, 2024

For the record, I reviewed most of this PR by doing a directory diff on the jQuery version of test/runner and the one from this PR using Kaleidoscope.

timmywil added 3 commits April 4, 2024 10:23
- one queue to rule them all: browserstack and selenium
- retries and hard retries are now supported in selenium
- selenium tests now re-use browsers in the same way as browserstack

Close jquerygh-508
@timmywil
Copy link
Member Author

timmywil commented Apr 4, 2024

I'm going to keep the separate commits by rebasing, but I've added a reference in each commit message to this PR.

@timmywil timmywil merged commit a3ed0ba into jquery:main Apr 4, 2024
timmywil added a commit that referenced this pull request Apr 4, 2024
timmywil added a commit that referenced this pull request Apr 4, 2024
@timmywil timmywil deleted the queue branch April 4, 2024 14:25
@mgol mgol modified the milestones: 3.5.0, 3.4.2 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants