Skip to content

CSS: Drop the cache in finalPropName #5583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgol merged 2 commits into from
Nov 25, 2024
Merged

CSS: Drop the cache in finalPropName #5583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
059568f
CSS: Drop the cache in finalPropName
mgol Nov 18, 2024
4c97827
fixup! CSS: Drop the cache in finalPropName
mgol Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/css/finalPropName.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { document } from "../var/document.js";

var cssPrefixes = [ "Webkit", "Moz", "ms" ],
emptyStyle = document.createElement( "div" ).style,
vendorProps = {};
emptyStyle = document.createElement( "div" ).style;

// Return a vendor-prefixed property or undefined
function vendorPropName( name ) {
Expand All @@ -21,13 +20,8 @@ function vendorPropName( name ) {

// Return a potentially-mapped vendor prefixed property
export function finalPropName( name ) {
var final = vendorProps[ name ];

if ( final ) {
return final;
}
if ( name in emptyStyle ) {
return name;
}
return vendorProps[ name ] = vendorPropName( name ) || name;
return vendorPropName( name ) || name;
}
34 changes: 24 additions & 10 deletions test/unit/css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,7 +1705,7 @@ QUnit.test( "Do not throw on frame elements from css method (trac-15098)", funct
( function() {
var vendorPrefixes = [ "Webkit", "Moz", "ms" ];

QUnit.test( "Don't default to a cached previously used wrong prefixed name (gh-2015)", function( assert ) {
QUnit.test( "Don't default to a previously used wrong prefixed name (gh-2015)", function( assert ) {

// Note: this test needs a property we know is only supported in a prefixed version
// by at least one of our main supported browsers. This may get out of date so let's
Expand Down Expand Up @@ -1759,18 +1759,32 @@ QUnit.test( "Do not throw on frame elements from css method (trac-15098)", funct
assert.equal( elemStyle.undefined, undefined, "Nothing writes to node.style.undefined" );
} );

QUnit.test( "Don't detect fake set properties on a node when caching the prefixed version", function( assert ) {
assert.expect( 1 );
} )();

var elem = jQuery( "<div></div>" ),
style = elem[ 0 ].style;
style.MozFakeProperty = "old value";
elem.css( "fakeProperty", "new value" );
QUnit.test( "Don't update existing unsupported prefixed properties", function( assert ) {
assert.expect( 1 );

assert.equal( style.MozFakeProperty, "old value", "Fake prefixed property is not cached" );
} );
var elem = jQuery( "<div></div>" ),
style = elem[ 0 ].style;
style.MozFakeProperty = "old value";
elem.css( "fakeProperty", "new value" );

} )();
assert.equal( style.MozFakeProperty, "old value", "Fake prefixed property is not set" );
} );

QUnit.test( "Don't set fake prefixed properties when a regular one is missing", function( assert ) {
assert.expect( 5 );

var elem = jQuery( "<div></div>" ),
style = elem[ 0 ].style;
elem.css( "fakeProperty", "fake value" );

assert.strictEqual( style.fakeProperty, "fake value", "Fake unprefixed property is set" );
assert.strictEqual( style.webkitFakeProperty, undefined, "Fake prefixed property is not set (webkit)" );
assert.strictEqual( style.WebkitFakeProperty, undefined, "Fake prefixed property is not set (Webkit)" );
assert.strictEqual( style.MozFakeProperty, undefined, "Fake prefixed property is not set (Moz)" );
assert.strictEqual( style.msFakeProperty, undefined, "Fake prefixed property is not set (ms)" );
} );

// IE doesn't support CSS variables.
QUnit.testUnlessIE( "css(--customProperty)", function( assert ) {
Expand Down
Loading