Skip to content

Selector: Remove jQuery.expr.filters #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgol wants to merge 1 commit into from
Closed

Selector: Remove jQuery.expr.filters #5569

mgol wants to merge 1 commit into from

Conversation

@mgol
Copy link
Member

@mgol mgol commented Oct 16, 2024

Summary

jQuery.expr.filters have been deprecated since jQuery 3.0.0 but this removal was missed along removing other deprecated APIs as it never made its way into the deprecated module. Let's remove it now. Migrate already patches the API.

It's unfortunate that we didn't also rename jQuery.expr.setFilters for
consistency, though... Perhaps we could still do it?

Checklist

@mgol
Selector: Remove jQuery.expr.filters
7e5dc2e 
`jQuery.expr.filters` have been deprecated since jQuery `3.0.0` but this removal
was missed along removing other deprecated APIs as it never made its way into
the `deprecated` module. Let's remove it now. Migrate already patches the API.
@mgol mgol added Selector Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Oct 16, 2024
@mgol
Copy link
Member Author

mgol commented Oct 16, 2024 •
edited
Loading

If we decide to rename jQuery.expr.setFilters, we should also do it in 3.x, perhaps releasing 3.8.0 instead of 3.7.0. That will also give us an opportunity to move deprecated selector stuff into the deprecated module there:

jquery/src/selector.js

Lines 2095 to 2097 in d41f0cd

// Deprecated
jQuery.expr[ ":" ] = jQuery.expr.pseudos;
jQuery.unique = jQuery.uniqueSort;

PR for this: #5570

mgol added a commit to mgol/jquery that referenced this pull request Oct 16, 2024
@mgol
Selector: Properly deprecate jQuery.expr[ ":" ]/jQuery.expr.filters
5d5fa8f 
Those APIs have formally been deprecated since `3.0.0`, but they never made its
way into the deprecated module.

Ref jquerygh-5569
@mgol mgol mentioned this pull request Oct 16, 2024
Merged
2 tasks
mgol added a commit to mgol/jquery that referenced this pull request Oct 16, 2024
@mgol
Selector: Properly deprecate jQuery.expr[ ":" ]/jQuery.expr.filters
ddc114e 
Those APIs have formally been deprecated since `3.0.0`, but they never made its
way into the deprecated module.

Ref jquerygh-5569
@timmywil
Copy link
Member

timmywil commented Nov 4, 2024

Won't this break a lot and not give us much space savings?

@timmywil
Copy link
Member

timmywil commented Nov 4, 2024

I don't think we need to rename setFilters. It should at least be deprecated, but should really get removed with POS selectors.

@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Nov 4, 2024
@mgol
Copy link
Member Author

mgol commented Nov 4, 2024

We've decided against this - setFilters is likely going away in 5.0.0 so it's not worth renaking it at this point. Instead, I'll submit a version of #5570 to the main branch.

@mgol mgol closed this Nov 4, 2024
@mgol mgol removed the Needs review label Nov 4, 2024
@mgol mgol deleted the remove-jQuery.expr.filters branch November 4, 2024 17:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Selector

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgol @timmywil