Skip to content

Build: Enforce ECMAScript 5 in tests via ESLint #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 2 commits into from
Oct 9, 2024
Merged

Build: Enforce ECMAScript 5 in tests via ESLint #5563

mgol merged 2 commits into from
Oct 9, 2024

Conversation

@neogy-akash
Copy link
Contributor

@neogy-akash neogy-akash commented Oct 7, 2024 •
edited
Loading

Summary

#5542 Changed the ecmaVersion for unit tests to ES5 from ES2015. Added Promise and Symbol keyword in globals and given them the value false to ignore them while linting tests. Polyfill added for this as well as per @mgol.

Checklist

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 7, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@neogy-akash neogy-akash mentioned this pull request Oct 7, 2024
Closed
mgol
mgol requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise looks good

@neogy-akash neogy-akash requested a review from mgol October 8, 2024 15:12
@mgol mgol added the Build label Oct 9, 2024
@mgol mgol added this to the 3.7.2 milestone Oct 9, 2024
@mgol mgol changed the title fix/5542 - ESLint should enforce ES 5 in tests Build: Enforce ECMAScript 5 in tests via ESLint Oct 9, 2024
@mgol mgol merged commit d74fc26 into jquery:main Oct 9, 2024
mgol pushed a commit that referenced this pull request Oct 9, 2024
@neogy-akash @mgol
Build: Enforce ECMAScript 5 in tests via ESLint
ce7db4a 
Fixes gh-5542
Closes gh-5563

(cherry picked from commit d74fc26)
@mgol
Copy link
Member

mgol commented Oct 9, 2024

Landed on main in d74fc26 and on 3.x-stable in ce7db4a. Thanks!

@neogy-akash
Copy link
Contributor Author

neogy-akash commented Oct 9, 2024

Landed on main in d74fc26 and on 3.x-stable in ce7db4a. Thanks!

This was my first open source contribution ever. Thanks for the guidance! @mgol

@miyasudokoro
Copy link

miyasudokoro commented Oct 18, 2024

@neogy-akash I've just made a pull request for updating eslint-config-jquery because it is full of deprecated tags. To update the tags, it would now have to pull in @stylistic/js as a plugin. Your code only pulls in the "rules" object but not the "plugins" object that would make it work, so I think another change in jquery itself will be necessary.

Of course, I don't even know if the maintainer of that project will accept my pull request, but I've done what I could.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

@mgol mgol mgol approved these changes

Assignees

No one assigned

Labels

Build

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@neogy-akash @mgol @miyasudokoro @timmywil