Skip to content

Build: upgrade dependencies; fix bundler tests on windows #5509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timmywil merged 2 commits into from
Jun 15, 2024
Merged

Build: upgrade dependencies; fix bundler tests on windows #5509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
900ab43
Build: upgrade dependencies; fix bundler tests on windows
timmywil Jun 12, 2024
24376a0
fixup! generalize test jquery ignore rule
timmywil Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/tasks/promises_aplus_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ async function runTests() {
spawn(
command,
[ test ].concat( args ),
{ stdio: "inherit" }
{ shell: true, stdio: "inherit" }
);
} );
}
Expand Down
26 changes: 24 additions & 2 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ export default [
ignores: [
"external",
"**/tmp",
"test/data/json_obj.js"
"test/data/json_obj.js",
"test/data/jquery-*.js"
]
},

Expand Down Expand Up @@ -147,7 +148,6 @@ export default [
"test/unit/**"
],
ignores: [
"test/data/jquery-3.7.1.js",
"test/data/badcall.js",
"test/data/badjson.js",
"test/data/support/csp.js",
Expand Down Expand Up @@ -349,6 +349,28 @@ export default [
}
},

{
files: [
"dist/jquery.slim.js",
"dist/jquery.factory.slim.js",
"dist-module/jquery.slim.module.js",
"dist-module/jquery.factory.slim.module.js"
],
rules: {

// Rollup is now smart enough to remove the use
// of parameters if the argument is not passed
// anywhere in the build.
// The removal of effects in the slim build
// results in some parameters not being used,
// which can be safely ignored.
"no-unused-vars": [
"error",
{ args: "none" }
]
}
},

{
files: [
"src/wrapper.js",
Expand Down
Loading