Tests: improve diffing for values of different types #5455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
force-pushed
the
diff-words-3.x
branch
from
dea27b0 to
9e8df57
Compare
timmywil
force-pushed
the
diff-words-3.x
branch
from
9e8df57 to
4e2c0f1
Compare
timmywil
force-pushed
the
diff-words-3.x
branch
from
9dbdad1 to
da08014
Compare
mgol
approved these changes
Mar 26, 2024
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
LGTM with the same suggestions as in the main PR.
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
3.x version of #5454
Differences are:
diffCharswhen both expected and actual are stringsdiffWordsfor everything after thatObjects, arrays, and numbers are diffed as before.
Checklist