Skip to content

Ajax: Allow processData: true even for binary data #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgol merged 1 commit into from
Mar 20, 2023
Merged

Ajax: Allow processData: true even for binary data #5205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/ajax/binary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ import jQuery from "../core.js";

import "../ajax.js";

jQuery.ajaxPrefilter( function( s ) {
jQuery.ajaxPrefilter( function( s, origOptions ) {

// Binary data needs to be passed to XHR as-is without stringification.
if ( typeof s.data !== "string" && !jQuery.isPlainObject( s.data ) ) {
if ( typeof s.data !== "string" && !jQuery.isPlainObject( s.data ) &&

// Don't disable data processing if explicitly set by the user.
!( "processData" in origOptions ) ) {
s.processData = false;
}

Expand Down
23 changes: 23 additions & 0 deletions test/unit/ajax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3148,4 +3148,27 @@ if ( typeof window.ArrayBuffer === "undefined" || typeof new XMLHttpRequest().re
};
} );

ajaxTest( "jQuery.ajax() - non-plain object", 1, function( assert ) {
return {
url: url( "mock.php?action=name" ),
method: "post",
data: Object.create( { name: "peter" } ),
success: function( data ) {
assert.strictEqual( data, "ERROR", "Data correctly not sent" );
}
};
} );

ajaxTest( "jQuery.ajax() - non-plain object with processData: true", 1, function( assert ) {
return {
url: url( "mock.php?action=name" ),
method: "post",
processData: true,
data: Object.create( { name: "peter" } ),
success: function( data ) {
assert.strictEqual( data, "pan", "Data sent correctly" );
}
};
} );

} )();