Support: ensure display is set to block for the support div #4844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes an issue with the support test in iframes in Android 8 Chrome 86+, where display: inline resulted in unexpected height values. Fixes jquerygh-4832
mgol
approved these changes
Feb 15, 2021
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
Nice catch!
We also need that for master, don't we?
Member
Author
|
@mgol Unclear. See gitter. |
This was referenced Mar 6, 2021
This was referenced Mar 13, 2021
This was referenced Mar 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where display: inline resulted in unexpected height values.
Fixes gh-4832
Summary
This PR fixes a support test failure in Chrome on Android 8.
Checklist