Selector: pass jQuery unit tests with selector-native #2703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ignore certain tests that obviously are not supported - Beefed up the sortOrder, uniqueSort, isXMLDoc, and attr functions Fixes jquerygh-1742 Fixes jquerygh-2048
timmywil
force-pushed
the
selector-native
branch
from
cbc08a2 to
75f24c8
Compare
Member
|
This looks awesome at first glance! |
test/unit/core.js
Outdated
Member
There was a problem hiding this comment.
Is there a way to mark such assertions as skipped (e.g., ok( true, … ) → ok( "skip", … ))? It won't bubble up to QUnit, but it might help us in the future.
Member
There was a problem hiding this comment.
I like the idea of marking individual tests somehow, and "skip" seems as good as any. Seems like it would be a useful QUnit feature as well?
Member
There was a problem hiding this comment.
It's come up before (qunitjs/qunit/pull/434, qunitjs/qunit/issues/326), but never really solidified enough. I'll give it some thought.
Member
|
Awesome work! |
Member
|
Honestly I wasn't ever sure we'd get this one done. Great work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1742
Fixes gh-2048