Event: Add basic unit tests for event aliases #2687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/unit/event.js
Outdated
Member
There was a problem hiding this comment.
An element under #qunit-fixture would probably be better than document.body, to make leaks even less likely.
At the moment it's not possible to run the full event unit tests without aliases so this was just tested with a custom build by running this one test.
Member
Author
|
All feedback incorporated. Unfortunately it's not possible at the moment to run all the event tests because they make scattered use of event aliases themselves. I opened #2691 for that. |
Member
|
LGTM. |
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need anything fancy here. A few questions inline.