Event: Ensure delegation doesn't error on comment nodes #2659
Conversation
|
This was fixed in Sizzle, right? Seems like the test is going to be brittle since these events are deprecated and will be removed eventually. If this is the only text-node event we need to guard against, how about if you add a check for DOMNodeInserted in this unit test before doing the actual test? That way we could do something like |
|
Sizzle still throws on text node input, but 9d820fb in jQuery protects it from seeing them. |
test/unit/event.js
Outdated
There was a problem hiding this comment.
The deprecation of DOMNodeInserted event could be addressed by a plan B that uses fireNative to synthesize an event on a comment node.
timmywil
force-pushed
the
gh-2055
branch
2 times, most recently
from
2e4f9fe to
cb273e5
Compare
|
Added fallback for when DOMNodeInserted is no longer supported. |
test/unit/event.js
Outdated
There was a problem hiding this comment.
This should be document.createComment, since we don't assert that jQuery.parseHTML handles comments (and in fact explicitly avoid doing so).
There was a problem hiding this comment.
Well, I wouldn't call that explicitly avoiding it, just explicitly accounting for their possible absence, but I forgot that some browsers remove them.
There was a problem hiding this comment.
I see, we mean the same thing, I think.
4 participants
From my preliminary tests, the
DOMNodeInsertedevent is still supported in our supported browsers.Fixes gh-2055