CSS: Make show/hide/toggle methods a module #2648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2193 Unit test changes some uses of .show() and .hide() to .css( "display", ... ), there was already an implicit assumption in several of the existing tests.
Member
|
LGTM |
Member
There was a problem hiding this comment.
While showHide does depend on effects, I don't think removing showHide should also remove effects.
Member
There was a problem hiding this comment.
However, removing effects should remove showHide: "effects": [ "css/showHide" ],
Member
Author
There was a problem hiding this comment.
If you don't remove effects, showHide will be pulled back in I think?
On the opposite side, you can remove effects but still want to use the non-animated .show() and .hide() methods so I don't think it should be force-removed.
Member
There was a problem hiding this comment.
You're right. I was only thinking of animations pertaining to .show() and .hide(), not all animations that need to show and hide elements.
|
good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2193
Unit test changes some uses of .show() and .hide() to .css( "display", ... ),
there was already an implicit assumption in several of the existing tests.