Skip to content

Event: Use form prop so that a propHook can be used #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrianolek wants to merge 1 commit into from
Closed

Event: Use form prop so that a propHook can be used #2575

adrianolek wants to merge 1 commit into from

Conversation

@adrianolek
Copy link

@adrianolek adrianolek commented Sep 6, 2015

As @gibson042 suggested, this enables 3rd party polyfills/workarounds to fix the IE8 delegated submit issues when HTML5 form attribute is used (see #2332 (comment), #2547 (comment))

Fixes gh-2332

@mgol
Copy link
Member

mgol commented Sep 6, 2015

LGTM.

@timmywil
Copy link
Member

timmywil commented Sep 6, 2015

Me too!

gibson042
gibson042 reviewed Sep 7, 2015
View reviewed changes
src/event.js Outdated
Copy link
Member

@gibson042 gibson042 Sep 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent premature reversion, I'd like to see a comment explaining why this line uses jQuery.prop instead of elem.form (e.g., like this). It should probably reference gh-2332, and be preceded by Support: IE <=8.

@adrianolek
Copy link
Author

adrianolek commented Sep 10, 2015

Question about cs; should I add the comment before var elem or leave it where it is now, but add blank line (for jscs)?

@mgol
Copy link
Member

mgol commented Sep 10, 2015

@adrianolek

Question about cs; should I add the comment before var elem or leave it where it is now, but add blank line (for jscs)?

The latter. It should be as close to where it applies as possible.

@mgol
Copy link
Member

mgol commented Sep 14, 2015

Landed at ead83b9, thanks!

@mgol mgol closed this Sep 14, 2015
mgol pushed a commit that referenced this pull request Sep 14, 2015
@adrianolek @mgol
Event: Use form prop so that a propHook can be used
ead83b9 
Fixes gh-2332
Closes gh-2575
@mgol mgol removed the Needs review label Sep 25, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adrianolek @mgol @timmywil @gibson042 @jquerybot