Manipulation: Switch rnoInnerhtml to a version more performant in IE #2574
Conversation
IE versions greater than 9 do not handle the old regular expression well with large html content This is due to the use of a non-capturing group after a very common html character (<). Test suite: http://jsfiddle.net/Lwa0t5rp/3/ Microsoft bug: https://connect.microsoft.com/IE/feedback/details/1736512/regular-expressions-are-slower-in-edge-than-in-ie8 Fixes jquerygh-2563 Closes jquerygh-2574
SeanHenderson
force-pushed
the
master
branch
from
80e66ff to
08477dd
Compare
|
@SeanHenderson A tip: you should never commit anything to This PR can stay based on |
|
(BTW, if you have JSHint errors on a freshly cloned repository, don't care about it too much - JSHint has broken our build so it's red temporarily...) |
|
I had a look created a branch tried to reset my master but failed. If it will not effect me in future I rather have this PR go in as is. |
|
@SeanHenderson Did you read my comment at #2568 (comment)? I think some other regexes might be affected as well. |
|
Hi I did read your comment and had a look at the performance of that regular expression. I saw it does have an issue but I do not have a suitable replacement at the moment. I traced the changes that introduced the optimised code path and can see it has changed quite bit over time. At one point regular expression was written similar to the way I have it now. I would prefer to create a separate PR for any changes to other regular expressions. |
|
@SeanHenderson OK, I landed this PR on both branches, thanks! If you had time to look at these other regexes, that'd be great. |
IE versions greater than 9 do not handle the old regular expression well with large html content. This is due to the use of a non-capturing group after a very common html character (<). Test suite: http://jsfiddle.net/Lwa0t5rp/3/ Microsoft bug: https://connect.microsoft.com/IE/feedback/details/1736512/ (cherry-picked from d4def22) Fixes gh-2563 Closes gh-2574
3 participants
IE versions greater than 9 do not handle the old regular expression well with large html content
This is due to the use of a non-capturing group after a very common html character (<).
Test suite: http://jsfiddle.net/Lwa0t5rp/3/
Microsoft bug: https://connect.microsoft.com/IE/feedback/details/1736512/regular-expressions-are-slower-in-edge-than-in-ie8
Fixes gh-2563
Closes gh-2574