Update code style, partially use new qunit interface, give test module a new name #2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://qunitjs.com/upgrade-guide-2.x/ For most of the boring work was used https://github.com/apsdehal/qunit-migrate package However, it can't update local qunit helpers, plus in some places old QUnit.asyncTest signature is still used Fixes jquerygh-2540
markelog
force-pushed
the
build
branch
3 times, most recently
from
9679cb2 to
69bee9c
Compare
Member
|
I'm against the "cache node_modules" part, see #2541 (comment). |
Member
There was a problem hiding this comment.
Are the parens still needed? I think it's no longer required by JSHint.
Member
Author
There was a problem hiding this comment.
Don't know, but that is not a subject of this PR, too much already is squashed in there :-)
Member
|
Overall, a good job! |
Member
There was a problem hiding this comment.
How does the dropdown from the screenshot at #2437 look like now? Is the double event entry changed to event & ready? Does choosing ready work?
markelog
changed the title
node_modules in CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-2056, gh-2437, gh-2540, gh-2571
On gh-2540
See http://qunitjs.com/upgrade-guide-2.x/
For most of the boring work was used https://github.com/apsdehal/qunit-migrate package
However, it can't update local
qunithelpers, plus in some places deprecatedQUnit.asyncTestmethod is still used.Some of these changes strongly depend on each other, others are also fixed, since i touched relevant files, so i decided to put them in one pull, i hope that is okay.